github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-16 07:56:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix QUERY_STRING variable

Browse Source 
QUERY_STRING should be populated using the raw string.
This commit is contained in:
Felipe Zimmerle 2015-07-21 23:02:55 -03:00
parent 7f76bb6df1
commit 6af9e8e42a
2 changed files with 46 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/assay.cc
View File

@ -214,6 +214,7 @@ int Assay::processURI(const char *uri, const char *protocol,
} else { } else {
store_variable("PATH_INFO", std::string(m_uri_decoded, 0, store_variable("PATH_INFO", std::string(m_uri_decoded, 0,
pos - m_uri_decoded.c_str())); pos - m_uri_decoded.c_str()));
store_variable("QUERY_STRING", std::string(strchr(m_uri, '?')));
} }
if (pos != NULL && strlen(pos) > 2) { if (pos != NULL && strlen(pos) > 2) {
@ -259,7 +260,6 @@ int Assay::processURI(const char *uri, const char *protocol,
debug(4, "Adding request argument (QUERY_STRING): name \"" + \ debug(4, "Adding request argument (QUERY_STRING): name \"" + \
key_value[0] + "\", value \"" + key_value[1] + "\""); key_value[0] + "\", value \"" + key_value[1] + "\"");
store_variable("QUERY_STRING:" + key_value[0], key_value[1]);
} }
} }
return true; return true;

45
test/test-cases/regression/variable-QUERY_STRING.json Normal file
View File

@ -0,0 +1,45 @@
[
{
"enabled":1,
"version_min":300000,
"title":"Testing Variables :: QUERY_STRING",
"client":{
"ip":"200.249.12.31",
"port":123
},
"server":{
"ip":"200.249.12.31",
"port":80
},
"request":{
"headers":{
"Host":"localhost",
"User-Agent":"curl/7.38.0",
"Accept":"*/*",
"Content-Length":"27",
"Content-Type":"application/x-www-form-urlencoded"
},
"uri":"/one/two/three?key1=value1&key2=v%20a%20l%20u%20e%202",
"protocol":"GET"
},
"response":{
"headers":{
"Date":"Mon, 13 Jul 2015 20:02:41 GMT",
"Last-Modified":"Sun, 26 Oct 2014 22:33:37 GMT",
"Content-Type":"text/html"
},
"body":[
"no need."
]
},
"expected":{
"debug_log":"key2=v\\%20a\\%20l\\%20u\\%20e\\%202\" \\(Variable: QUERY_STRING\\)"
},
"rules":[
"SecRuleEngine On",
"SecDebugLog \/tmp\/modsec_debug.log",
"SecDebugLogLevel 9",
"SecRule QUERY_STRING \"@contains test \" \"phase:3,pass,t:trim\""
]
}
]