github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-09-29 19:24:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Properly cleanup XML parser contexts upon completion

Browse Source 
It is currently possible that the XML parsing context is not properly
cleaned up if a parsed XML document is malformed.

This fix makes sure that the context is taken care of.

Signed-off-by: Vladimir Krivopalov <vlkrivop@microsoft.com>
This commit is contained in:
Vladimir Krivopalov
2020-01-13 16:36:09 -08:00
parent 624bd2bf82
commit 6a5ec1ff7b
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
apache2/msc_xml.c
View File

@@ -137,6 +137,13 @@ int xml_complete(modsec_rec *msr, char **error_msg) {
* Frees the resources used for XML parsing. * Frees the resources used for XML parsing.
*/ */
apr_status_t xml_cleanup(modsec_rec *msr) { apr_status_t xml_cleanup(modsec_rec *msr) {
if (msr->xml->parsing_ctx != NULL) {
if (msr->xml->parsing_ctx->myDoc) {
xmlFreeDoc(msr->xml->parsing_ctx->myDoc);
}
xmlFreeParserCtxt(msr->xml->parsing_ctx);
msr->xml->parsing_ctx = NULL;
}
if (msr->xml->doc != NULL) { if (msr->xml->doc != NULL) {
xmlFreeDoc(msr->xml->doc); xmlFreeDoc(msr->xml->doc);
msr->xml->doc = NULL; msr->xml->doc = NULL;