Cosmetics: address cppcheck warnings on src/variables

This commit is contained in:
Felipe Zimmerle
2020-01-27 08:47:30 -03:00
parent ff9152ed74
commit 68ef2dece3
23 changed files with 58 additions and 57 deletions

View File

@@ -34,7 +34,7 @@ namespace variables {
class Tx_DictElement : public Variable {
public:
explicit Tx_DictElement(std::string dictElement)
explicit Tx_DictElement(const std::string &dictElement)
: Variable("TX:" + dictElement),
m_dictElement("TX:" + dictElement) { }
@@ -65,7 +65,7 @@ class Tx_NoDictElement : public Variable {
class Tx_DictElementRegexp : public VariableRegex {
public:
explicit Tx_DictElementRegexp(std::string dictElement)
explicit Tx_DictElementRegexp(const std::string &dictElement)
: VariableRegex("TX", dictElement),
m_dictElement(dictElement) { }
@@ -94,11 +94,11 @@ class Tx_DynamicElement : public Variable {
m_keyExclusion);
}
void del(Transaction *t, std::string k) {
static void del(Transaction *t, const std::string &k) {
t->m_collections.m_tx_collection->del(k);
}
void storeOrUpdateFirst(Transaction *t, std::string var,
static void storeOrUpdateFirst(Transaction *t, const std::string &var,
std::string value) {
t->m_collections.m_tx_collection->storeOrUpdateFirst(var, value);
}