diff --git a/CHANGES b/CHANGES index fd7b1781..a8fdc999 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,11 @@ 14 Feb 2010 - 2.5.13-dev1 ------------------------- + * Remove the ability to use a relative path to a piped audit logger + (i.e. mlogc) as Apache does not support it in their piped loggers + and it was breaking Windows and probably other platforms that + use spaces in filesystem paths. Discovered by Tom Donovan. + * Fix memory leak freeing regex. Discovered by Tom Donovan. * Fix some portability issues on Windows. diff --git a/apache2/apache2_config.c b/apache2/apache2_config.c index 153d5cb1..c89cbd65 100644 --- a/apache2/apache2_config.c +++ b/apache2/apache2_config.c @@ -953,7 +953,7 @@ static const char *cmd_audit_log(cmd_parms *cmd, void *_dcfg, const char *p1) dcfg->auditlog_name = (char *)p1; if (dcfg->auditlog_name[0] == '|') { - const char *pipe_name = ap_server_root_relative(cmd->pool, dcfg->auditlog_name + 1); + const char *pipe_name = dcfg->auditlog_name + 1; piped_log *pipe_log; pipe_log = ap_open_piped_log(cmd->pool, pipe_name); diff --git a/doc/modsecurity2-apache-reference.xml b/doc/modsecurity2-apache-reference.xml index f3ba970f..eef40c5d 100644 --- a/doc/modsecurity2-apache-reference.xml +++ b/doc/modsecurity2-apache-reference.xml @@ -673,6 +673,13 @@ SecAuditLogStorageDir logs/audit configure and use the ModSecurity Log Collector (mlogc) and use the following format for the audit log: + + Prior to 2.5.13 you may have been able to use a relative path to + a piped logger command, but this was broken on some platforms and the + feature was removed in 2.5.13 to make the platforms more + consitent. + + SecAuditLog "|/path/to/mlogc /path/to/mlogc.conf"