cppcheck: make static analysis more pedantic

This commit is contained in:
Felipe Zimmerle
2020-01-17 11:41:05 -03:00
parent cd9b8aa93b
commit 4f13fecbaf
23 changed files with 58 additions and 42 deletions

View File

@@ -28,7 +28,7 @@ namespace modsecurity {
namespace variables {
Variable::Variable(std::string name)
Variable::Variable(const std::string &name)
: m_name(name),
m_collectionName("") {
size_t a = m_name.find(":");

View File

@@ -539,7 +539,7 @@ class VariableMonkeyResolution {
class Variable : public VariableMonkeyResolution {
public:
explicit Variable(std::string _name);
explicit Variable(const std::string &name);
explicit Variable(Variable *_name);
virtual ~Variable() { }

View File

@@ -42,7 +42,7 @@ class XML_NoDictElement : public Variable {
m_var(&m_name, &m_plain) {
}
void evaluate(Transaction *transaction,
void evaluate(Transaction *t,
Rule *rule,
std::vector<const VariableValue *> *l) override {
l->push_back(new VariableValue(&m_var));