From 450c966da0d03daa077a2198f16514ec7fb3a2f4 Mon Sep 17 00:00:00 2001 From: Felipe Zimmerle Date: Thu, 1 Mar 2018 11:36:31 -0300 Subject: [PATCH] Fix a set of compilation warnings --- CHANGES | 2 ++ headers/modsecurity/rule.h | 2 +- src/operators/rx.h | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index 9764fcaf..0cd00c92 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,8 @@ v3.0.x - YYYY-MMM-DD (To be released) ------------------------------------- + - Fix a set of compilation warnings + [Issue #1650 - @zimmerle, @JayCase] - Check for disruptive action on SecDefaultAction. [Issue #1614 - @zimmerle, @michaelgranzow-avi] - Fix block-block infinite loop. diff --git a/headers/modsecurity/rule.h b/headers/modsecurity/rule.h index db763bb0..01f6cfb4 100644 --- a/headers/modsecurity/rule.h +++ b/headers/modsecurity/rule.h @@ -50,7 +50,7 @@ class Rule { std::string fileName, int lineNumber); explicit Rule(std::string marker); - ~Rule(); + virtual ~Rule(); virtual bool evaluate(Transaction *transaction, std::shared_ptr rm); diff --git a/src/operators/rx.h b/src/operators/rx.h index 654e8fe7..7460c396 100644 --- a/src/operators/rx.h +++ b/src/operators/rx.h @@ -60,7 +60,7 @@ class Rx : public Operator { const std::string& input, std::shared_ptr ruleMessage) override; - bool init(const std::string &arg, std::string *error); + bool init(const std::string &arg, std::string *error) override; private: Regex *m_re;