github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-15 23:55:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Refactor: replaced 3 declarations with 3 structured binding declarations.

Browse Source 
This syntax is far more expressive and easier to understand than the old one.

Refactor: flipped the conditions in "if (contains[Tag|Msg|Id]( ... " statements
for clearer code.

Refactor: moved "Variable *b" as an init-statement inside "if()" statements for
stricter scope.

Reference: https://sonarcloud.io/project/issues?open=AY8-ff1vm_fzkWiCOtCt&id=owasp-modsecurity_ModSecurity
This commit is contained in:
gberkes 2024-08-07 17:55:30 +02:00
parent e8db92ebb0
commit 35e825d643
1 changed files with 21 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/rule_with_operator.cc
View File

@ -133,45 +133,33 @@ bool RuleWithOperator::executeOperatorAt(Transaction *trans, const std::string &
void RuleWithOperator::getVariablesExceptions(Transaction *t, void RuleWithOperator::getVariablesExceptions(Transaction *t,
variables::Variables *exclusion, variables::Variables *addition) { variables::Variables *exclusion, variables::Variables *addition) {
for (const auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer for (const auto &[tag, v] : t->m_rules->m_exceptions.m_variable_update_target_by_tag) { // cppcheck-suppress ctunullpointer
if (containsTag(*a.first.get(), t) == false) { if (containsTag(*tag.get(), t)) {
continue; if (Variable *b{v.get()};dynamic_cast<variables::VariableModificatorExclusion*>(b)) {
} exclusion->push_back(dynamic_cast<variables::VariableModificatorExclusion*>(b)->m_base.get());
Variable *b = a.second.get(); } else {
if (dynamic_cast<variables::VariableModificatorExclusion*>(b)) { addition->push_back(b);
exclusion->push_back( }
dynamic_cast<variables::VariableModificatorExclusion*>(
b)->m_base.get());
} else {
addition->push_back(b);
} }
} }
for (const auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_msg) { for (const auto &[msg, v] : t->m_rules->m_exceptions.m_variable_update_target_by_msg) {
if (containsMsg(*a.first.get(), t) == false) { if (containsMsg(*msg.get(), t)) {
continue; if (Variable *b{v.get()}; dynamic_cast<variables::VariableModificatorExclusion *>(b)) {
} exclusion->push_back(dynamic_cast<variables::VariableModificatorExclusion *>(b)->m_base.get());
Variable *b = a.second.get(); } else {
if (dynamic_cast<variables::VariableModificatorExclusion*>(b)) { addition->push_back(b);
exclusion->push_back( }
dynamic_cast<variables::VariableModificatorExclusion*>(
b)->m_base.get());
} else {
addition->push_back(b);
} }
} }
for (const auto &a : t->m_rules->m_exceptions.m_variable_update_target_by_id) { for (const auto &[id, v] : t->m_rules->m_exceptions.m_variable_update_target_by_id) {
if (m_ruleId != a.first) { if (m_ruleId == id) {
continue; if (Variable *b{v.get()};dynamic_cast<variables::VariableModificatorExclusion *>(b)) {
} exclusion->push_back(dynamic_cast<variables::VariableModificatorExclusion *>(b)->m_base.get());
Variable *b = a.second.get(); } else {
if (dynamic_cast<variables::VariableModificatorExclusion*>(b)) { addition->push_back(b);
exclusion->push_back( }
dynamic_cast<variables::VariableModificatorExclusion*>(
b)->m_base.get());
} else {
addition->push_back(b);
} }
} }
} }