github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-10-01 12:07:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

Testing performance enhancements by enabling transformations cache

Browse Source 
Also reduce the utilization of dynamic cast.
This commit is contained in:
Felipe Zimmerle
2015-11-04 00:28:04 -03:00
parent e641c3cc17
commit 2ee5d4ca8f
12 changed files with 80 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/rule.cc
View File

@@ -140,8 +140,7 @@ bool Rule::evaluateActions(Assay *assay) {
bool containsDisruptive = false;
// int transformations = 0;
for (Action *a : this->actions_runtime_pre) {
None *z = dynamic_cast<None *>(a);
if (z != NULL) {
if (a->m_isNone) {
none++;
}
}
@@ -165,7 +164,6 @@ bool Rule::evaluateActions(Assay *assay) {
}
for (Action *a : this->actions_runtime_pre) {
None *z = dynamic_cast<None *>(a);
/*
if (none == 0) {
value = a->evaluate(value, assay);
@@ -175,7 +173,7 @@ bool Rule::evaluateActions(Assay *assay) {
transformations++;
}
*/
if (z != NULL) {
if (a->m_isNone) {
none--;
}
}
@@ -281,9 +279,7 @@ bool Rule::evaluate(Assay *assay) {
std::list<std::string> exclusions;
for (int i = 0; i < variables->size(); i++) {
Variable *variable = variables->at(i);
Exclusion *exl = dynamic_cast<Exclusion *>(variable);
if (exl != NULL) {
if (variable->m_isExclusion) {
std::list<transaction::Variable *> *z =
variable->evaluate(assay);
for (auto &y : *z) {
@@ -297,8 +293,7 @@ bool Rule::evaluate(Assay *assay) {
for (int i = 0; i < variables->size(); i++) {
int transformations = 0;
Variable *variable = variables->at(i);
Exclusion *exl = dynamic_cast<Exclusion *>(variable);
if (exl != NULL) {
if (variable->m_isExclusion) {
continue;
}
@@ -317,8 +312,7 @@ bool Rule::evaluate(Assay *assay) {
std::string value = v->m_value;
int none = 0;
for (Action *a : this->actions_runtime_pre) {
None *z = dynamic_cast<None *>(a);
if (z != NULL) {
if (a->m_isNone != NULL) {
none++;
}
}
@@ -342,7 +336,6 @@ bool Rule::evaluate(Assay *assay) {
}
for (Action *a : this->actions_runtime_pre) {
None *z = dynamic_cast<None *>(a);
if (none == 0) {
value = a->evaluate(value, assay);
#ifndef NO_LOGS
@@ -352,7 +345,7 @@ bool Rule::evaluate(Assay *assay) {
#endif
transformations++;
}
if (z != NULL) {
if (a->m_isNone != NULL) {
none--;
}
}