From 2657154eaa156d66a1fdc032d67ac06030e386e3 Mon Sep 17 00:00:00 2001
From: brectanus <brectanus@9017d574-64ec-4062-9424-5e00b32a252b>
Date: Tue, 18 Dec 2007 22:50:01 +0000
Subject: [PATCH] Update docs for t:md5 and t:sha1 to note that they are in
 binary form and should be hex encoded to be human readable.

---
 doc/modsecurity2-apache-reference.xml | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/doc/modsecurity2-apache-reference.xml b/doc/modsecurity2-apache-reference.xml
index 37026a1d..2538bf7b 100644
--- a/doc/modsecurity2-apache-reference.xml
+++ b/doc/modsecurity2-apache-reference.xml
@@ -3404,7 +3404,9 @@ SecRule <emphasis>XML:/xq:employees/employee/name/text()</emphasis> Fred \
     <section>
       <title><literal>md5</literal></title>
 
-      <para>This function calculates an MD5 hash from input.</para>
+      <para>This function calculates an MD5 hash from input.  Note that
+      the computed hash is in a raw binary form and should be hex encoded
+      to be human readable (t:md5,t:hexEncode).</para>
     </section>
 
     <section>
@@ -3493,7 +3495,9 @@ SecRule <emphasis>XML:/xq:employees/employee/name/text()</emphasis> Fred \
     <section>
       <title><literal>sha1</literal></title>
 
-      <para>This function calculates a SHA1 hash from input.</para>
+      <para>This function calculates a SHA1 hash from input.  Note that
+      the computed hash is in a raw binary form and should be hex encoded
+      to be human readable (t:sha1,t:hexEncode).</para>
     </section>
 
     <section>
@@ -4636,7 +4640,7 @@ SecRule &amp;REQUEST_HEADERS:Accept "@eq 0" \
 
       <programlisting format="linespecific">SecDefaultAction log,deny,phase:1,t:removeNulls,t:lowercase 
 SecRule REQUEST_COOKIES:SESSIONID "47414e81cbbef3cf8366e84eeacba091" \
-    log,deny,status:403,<emphasis>t:md5</emphasis></programlisting>
+    log,deny,status:403,<emphasis>t:md5,t:hexEncode</emphasis></programlisting>
 
       <para><emphasis>Note</emphasis></para>
 
@@ -5209,4 +5213,4 @@ SecRule REQUEST_METHOD "!<emphasis>@within %{tx.allowed_methods}</emphasis>" t:l
       </section>
     </section>
   </section>
-</article>
\ No newline at end of file
+</article>