Refactoring: rename evaluate to execute on actions

This commit is contained in:
Felipe Zimmerle 2019-02-25 21:47:51 -03:00
parent 6cdbad05ad
commit 1f7d202985
No known key found for this signature in database
GPG Key ID: E6DFB08CE8B11277
170 changed files with 234 additions and 239 deletions

View File

@ -47,7 +47,7 @@ class Action {
m_parser_payload("") { m_parser_payload("") {
set_name_and_payload(_action); set_name_and_payload(_action);
} }
explicit Action(const std::string& _action, int kind) Action(const std::string& _action, int kind)
: m_isNone(false), : m_isNone(false),
temporaryAction(false), temporaryAction(false),
action_kind(kind), action_kind(kind),
@ -65,12 +65,12 @@ class Action {
virtual ~Action() { } virtual ~Action() { }
virtual std::string evaluate(const std::string &exp, virtual std::string execute(const std::string &exp,
Transaction *transaction); Transaction *transaction);
virtual bool evaluate(RuleWithActions *rule, Transaction *transaction); virtual bool execute(RuleWithActions *rule, Transaction *transaction);
virtual bool evaluate(RuleWithActions *rule, Transaction *transaction, virtual bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &ruleMessage) { RuleMessage &ruleMessage) {
return evaluate(rule, transaction); return execute(rule, transaction);
} }
virtual bool init(std::string *error) { return true; } virtual bool init(std::string *error) { return true; }
virtual bool isDisruptive() { return false; } virtual bool isDisruptive() { return false; }

View File

@ -39,7 +39,8 @@ bool Accuracy::init(std::string *error) {
} }
bool Accuracy::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Accuracy::execute(RuleWithActions *rule, Transaction *transaction) {
rule->setAccuracy(m_accuracy);
return true; return true;
} }

View File

@ -33,7 +33,7 @@ class Accuracy : public Action {
: Action(action, ConfigurationKind), : Action(action, ConfigurationKind),
m_accuracy(0) { } m_accuracy(0) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
int getAccuracy() const { return m_accuracy; } int getAccuracy() const { return m_accuracy; }

View File

@ -45,13 +45,13 @@ namespace modsecurity {
namespace actions { namespace actions {
std::string Action::evaluate(const std::string &value, std::string Action::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
return value; return value;
} }
bool Action::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Action::execute(RuleWithActions *rule, Transaction *transaction) {
return true; return true;
} }

View File

@ -27,7 +27,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool AuditLog::evaluate(RuleWithActions *rule, Transaction *transaction, bool AuditLog::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
transaction->messageSetNoAuditLog(false); transaction->messageSetNoAuditLog(false);
return true; return true;

View File

@ -35,7 +35,7 @@ class AuditLog : public Action {
explicit AuditLog(const std::string &action) explicit AuditLog(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
}; };

View File

@ -29,7 +29,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool Block::evaluate(RuleWithActions *rule, Transaction *transaction, bool Block::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
ms_dbg_a(transaction, 8, "Marking request as disruptive."); ms_dbg_a(transaction, 8, "Marking request as disruptive.");
return true; return true;

View File

@ -35,7 +35,7 @@ class Block : public Action {
public: public:
explicit Block(const std::string &action) : Action(action) { } explicit Block(const std::string &action) : Action(action) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
}; };

View File

@ -32,7 +32,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool Capture::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Capture::execute(RuleWithActions *rule, Transaction *transaction) {
return true; return true;
} }

View File

@ -31,7 +31,7 @@ class Capture : public Action {
explicit Capture(const std::string &action) explicit Capture(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };

View File

@ -25,7 +25,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool Chain::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Chain::execute(RuleWithActions *rule, Transaction *transaction) {
rule->setHasChainAction(true); rule->setHasChainAction(true);
return true; return true;
} }

View File

@ -35,7 +35,7 @@ class Chain : public Action {
explicit Chain(const std::string &action) explicit Chain(const std::string &action)
: Action(action, ConfigurationKind) { } : Action(action, ConfigurationKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };
} // namespace actions } // namespace actions

View File

@ -38,7 +38,7 @@ bool AuditLogParts::init(std::string *error) {
return true; return true;
} }
bool AuditLogParts::evaluate(RuleWithActions *rule, Transaction *transaction) { bool AuditLogParts::execute(RuleWithActions *rule, Transaction *transaction) {
transaction->m_auditLogModifier.push_back( transaction->m_auditLogModifier.push_back(
std::make_pair(mPartsAction, mParts)); std::make_pair(mPartsAction, mParts));
return true; return true;

View File

@ -33,7 +33,7 @@ class AuditLogParts : public Action {
mPartsAction(0), mPartsAction(0),
mParts("") { } mParts("") { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
protected: protected:

View File

@ -42,7 +42,7 @@ bool RequestBodyAccess::init(std::string *error) {
return true; return true;
} }
bool RequestBodyAccess::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RequestBodyAccess::execute(RuleWithActions *rule, Transaction *transaction) {
if (m_request_body_access) { if (m_request_body_access) {
transaction->m_requestBodyAccess = RulesSetProperties::TrueConfigBoolean; transaction->m_requestBodyAccess = RulesSetProperties::TrueConfigBoolean;
} else { } else {

View File

@ -34,7 +34,7 @@ class RequestBodyAccess : public Action {
m_request_body_access(false) { } m_request_body_access(false) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool m_request_body_access; bool m_request_body_access;
}; };

View File

@ -25,7 +25,7 @@ namespace actions {
namespace ctl { namespace ctl {
bool RequestBodyProcessorJSON::evaluate(RuleWithActions *rule, bool RequestBodyProcessorJSON::execute(RuleWithActions *rule,
Transaction *transaction) { Transaction *transaction) {
transaction->m_requestBodyProcessor = Transaction::JSONRequestBody; transaction->m_requestBodyProcessor = Transaction::JSONRequestBody;
transaction->m_variableReqbodyProcessor.set("JSON", transaction->m_variableReqbodyProcessor.set("JSON",

View File

@ -31,7 +31,7 @@ class RequestBodyProcessorJSON : public Action {
explicit RequestBodyProcessorJSON(const std::string &action) explicit RequestBodyProcessorJSON(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };

View File

@ -25,7 +25,7 @@ namespace actions {
namespace ctl { namespace ctl {
bool RequestBodyProcessorURLENCODED::evaluate(RuleWithActions *rule, bool RequestBodyProcessorURLENCODED::execute(RuleWithActions *rule,
Transaction *transaction) { Transaction *transaction) {
transaction->m_requestBodyType = Transaction::WWWFormUrlEncoded; transaction->m_requestBodyType = Transaction::WWWFormUrlEncoded;
transaction->m_variableReqbodyProcessor.set("URLENCODED", transaction->m_variableReqbodyProcessor.set("URLENCODED",

View File

@ -31,7 +31,7 @@ class RequestBodyProcessorURLENCODED : public Action {
explicit RequestBodyProcessorURLENCODED(const std::string &action) explicit RequestBodyProcessorURLENCODED(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };

View File

@ -25,7 +25,7 @@ namespace actions {
namespace ctl { namespace ctl {
bool RequestBodyProcessorXML::evaluate(RuleWithActions *rule, bool RequestBodyProcessorXML::execute(RuleWithActions *rule,
Transaction *transaction) { Transaction *transaction) {
transaction->m_requestBodyProcessor = Transaction::XMLRequestBody; transaction->m_requestBodyProcessor = Transaction::XMLRequestBody;
transaction->m_variableReqbodyProcessor.set("XML", transaction->m_variableReqbodyProcessor.set("XML",

View File

@ -31,7 +31,7 @@ class RequestBodyProcessorXML : public Action {
explicit RequestBodyProcessorXML(const std::string &action) explicit RequestBodyProcessorXML(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };

View File

@ -45,7 +45,7 @@ bool RuleEngine::init(std::string *error) {
return true; return true;
} }
bool RuleEngine::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleEngine::execute(RuleWithActions *rule, Transaction *transaction) {
std::stringstream a; std::stringstream a;
a << "Setting SecRuleEngine to "; a << "Setting SecRuleEngine to ";
a << modsecurity::RulesSetProperties::ruleEngineStateString(m_ruleEngine); a << modsecurity::RulesSetProperties::ruleEngineStateString(m_ruleEngine);

View File

@ -35,7 +35,7 @@ class RuleEngine : public Action {
m_ruleEngine(RulesSetProperties::PropertyNotSetRuleEngine) { } m_ruleEngine(RulesSetProperties::PropertyNotSetRuleEngine) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
RulesSetProperties::RuleEngine m_ruleEngine; RulesSetProperties::RuleEngine m_ruleEngine;
}; };

View File

@ -83,7 +83,7 @@ bool RuleRemoveById::init(std::string *error) {
return false; return false;
} }
bool RuleRemoveById::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleRemoveById::execute(RuleWithActions *rule, Transaction *transaction) {
for (auto &i : m_ids) { for (auto &i : m_ids) {
transaction->m_ruleRemoveById.push_back(i); transaction->m_ruleRemoveById.push_back(i);
} }

View File

@ -33,7 +33,7 @@ class RuleRemoveById : public Action {
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
std::list<std::pair<int, int> > m_ranges; std::list<std::pair<int, int> > m_ranges;
std::list<int> m_ids; std::list<int> m_ids;

View File

@ -32,7 +32,7 @@ bool RuleRemoveByTag::init(std::string *error) {
return true; return true;
} }
bool RuleRemoveByTag::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleRemoveByTag::execute(RuleWithActions *rule, Transaction *transaction) {
transaction->m_ruleRemoveByTag.push_back(m_tag); transaction->m_ruleRemoveByTag.push_back(m_tag);
return true; return true;
} }

View File

@ -34,7 +34,7 @@ class RuleRemoveByTag : public Action {
m_tag("") { } m_tag("") { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
std::string m_tag; std::string m_tag;
}; };

View File

@ -51,7 +51,7 @@ bool RuleRemoveTargetById::init(std::string *error) {
return true; return true;
} }
bool RuleRemoveTargetById::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleRemoveTargetById::execute(RuleWithActions *rule, Transaction *transaction) {
transaction->m_ruleRemoveTargetById.push_back( transaction->m_ruleRemoveTargetById.push_back(
std::make_pair(m_id, m_target)); std::make_pair(m_id, m_target));
return true; return true;

View File

@ -35,7 +35,7 @@ class RuleRemoveTargetById : public Action {
m_target("") { } m_target("") { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
int m_id; int m_id;
std::string m_target; std::string m_target;

View File

@ -44,7 +44,7 @@ bool RuleRemoveTargetByTag::init(std::string *error) {
return true; return true;
} }
bool RuleRemoveTargetByTag::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleRemoveTargetByTag::execute(RuleWithActions *rule, Transaction *transaction) {
transaction->m_ruleRemoveTargetByTag.push_back( transaction->m_ruleRemoveTargetByTag.push_back(
std::make_pair(m_tag, m_target)); std::make_pair(m_tag, m_target));
return true; return true;

View File

@ -33,7 +33,7 @@ class RuleRemoveTargetByTag : public Action {
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
std::string m_tag; std::string m_tag;
std::string m_target; std::string m_target;

View File

@ -38,7 +38,7 @@ bool Status::init(std::string *error) {
} }
bool Status::evaluate(RuleWithActions *rule, Transaction *transaction, bool Status::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
transaction->m_it.status = m_status; transaction->m_it.status = m_status;
return true; return true;

View File

@ -37,7 +37,7 @@ class Status : public Action {
m_status(0) { } m_status(0) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
int m_status; int m_status;

View File

@ -49,7 +49,7 @@ bool Allow::init(std::string *error) {
} }
bool Allow::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Allow::execute(RuleWithActions *rule, Transaction *transaction) {
ms_dbg_a(transaction, 4, "Dropping the evaluation of upcoming rules " \ ms_dbg_a(transaction, 4, "Dropping the evaluation of upcoming rules " \
"in favor of an `allow' action of type: " \ "in favor of an `allow' action of type: " \
+ allowTypeToName(m_allowType)); + allowTypeToName(m_allowType));

View File

@ -59,7 +59,7 @@ class Allow : public Action {
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool isDisruptive() override { return true; } bool isDisruptive() override { return true; }
AllowType m_allowType; AllowType m_allowType;

View File

@ -28,7 +28,7 @@ namespace actions {
namespace disruptive { namespace disruptive {
bool Deny::evaluate(RuleWithActions *rule, Transaction *transaction, bool Deny::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
ms_dbg_a(transaction, 8, "Running action deny"); ms_dbg_a(transaction, 8, "Running action deny");

View File

@ -33,7 +33,7 @@ class Deny : public Action {
public: public:
explicit Deny(const std::string &action) : Action(action) { } explicit Deny(const std::string &action) : Action(action) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
bool isDisruptive() override { return true; } bool isDisruptive() override { return true; }
}; };

View File

@ -32,7 +32,7 @@ namespace actions {
namespace disruptive { namespace disruptive {
bool Drop::evaluate(RuleWithActions *rule, Transaction *transaction, bool Drop::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
ms_dbg_a(transaction, 8, "Running action drop " \ ms_dbg_a(transaction, 8, "Running action drop " \
"[executing deny instead of drop.]"); "[executing deny instead of drop.]");

View File

@ -32,7 +32,7 @@ class Drop : public Action {
public: public:
explicit Drop(const std::string &action) : Action(action) { } explicit Drop(const std::string &action) : Action(action) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
bool isDisruptive() override { return true; } bool isDisruptive() override { return true; }
}; };

View File

@ -29,7 +29,7 @@ namespace actions {
namespace disruptive { namespace disruptive {
bool Pass::evaluate(RuleWithActions *rule, Transaction *transaction, bool Pass::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
intervention::free(&transaction->m_it); intervention::free(&transaction->m_it);
intervention::reset(&transaction->m_it); intervention::reset(&transaction->m_it);

View File

@ -31,7 +31,7 @@ class Pass : public Action {
public: public:
explicit Pass(const std::string &action) : Action(action) { } explicit Pass(const std::string &action) : Action(action) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
bool isDisruptive() override { return true; } bool isDisruptive() override { return true; }
}; };

View File

@ -34,7 +34,7 @@ bool Redirect::init(std::string *error) {
} }
bool Redirect::evaluate(RuleWithActions *rule, Transaction *transaction, bool Redirect::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
std::string m_urlExpanded(m_string->evaluate(transaction)); std::string m_urlExpanded(m_string->evaluate(transaction));
/* if it was changed before, lets keep it. */ /* if it was changed before, lets keep it. */

View File

@ -46,7 +46,7 @@ class Redirect : public Action {
m_status(0), m_status(0),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
bool init(std::string *error) override; bool init(std::string *error) override;
bool isDisruptive() override { return true; } bool isDisruptive() override { return true; }

View File

@ -49,7 +49,7 @@ bool Exec::init(std::string *error) {
} }
bool Exec::evaluate(RuleWithActions *rule, Transaction *t) { bool Exec::execute(RuleWithActions *rule, Transaction *t) {
ms_dbg_a(t, 8, "Running script... " + m_script); ms_dbg_a(t, 8, "Running script... " + m_script);
m_lua.run(t); m_lua.run(t);
return true; return true;

View File

@ -36,7 +36,7 @@ class Exec : public Action {
~Exec() { } ~Exec() { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -54,7 +54,7 @@ bool InitCol::init(std::string *error) {
} }
bool InitCol::evaluate(RuleWithActions *rule, Transaction *t) { bool InitCol::execute(RuleWithActions *rule, Transaction *t) {
std::string collectionName(m_string->evaluate(t)); std::string collectionName(m_string->evaluate(t));
if (m_collection_key == "ip") { if (m_collection_key == "ip") {

View File

@ -38,7 +38,7 @@ class InitCol : public Action {
: Action(action, RunTimeOnlyIfMatchKind), : Action(action, RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:
std::string m_collection_key; std::string m_collection_key;

View File

@ -28,7 +28,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool Log::evaluate(RuleWithActions *rule, Transaction *transaction, bool Log::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
return true; return true;
} }

View File

@ -33,7 +33,7 @@ class Log : public Action {
explicit Log(const std::string &action) explicit Log(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
}; };

View File

@ -29,7 +29,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool LogData::evaluate(RuleWithActions *rule, Transaction *transaction, bool LogData::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
rm.m_data = data(transaction); rm.m_data = data(transaction);

View File

@ -39,7 +39,7 @@ class LogData : public Action {
: Action("logdata", RunTimeOnlyIfMatchKind), : Action("logdata", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
std::string data(Transaction *Transaction); std::string data(Transaction *Transaction);

View File

@ -39,7 +39,7 @@ bool Maturity::init(std::string *error) {
} }
bool Maturity::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Maturity::execute(RuleWithActions *rule, Transaction *transaction) {
return true; return true;
} }

View File

@ -33,7 +33,7 @@ class Maturity : public Action {
: Action(action, ConfigurationKind), : Action(action, ConfigurationKind),
m_maturity(0) { } m_maturity(0) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
int getMaturity() const { return m_maturity; } int getMaturity() const { return m_maturity; }

View File

@ -46,7 +46,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool Msg::evaluate(RuleWithActions *rule, Transaction *transaction, bool Msg::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
std::string msg = data(transaction); std::string msg = data(transaction);
rm.m_message = msg; rm.m_message = msg;

View File

@ -40,7 +40,7 @@ class Msg : public Action {
: Action("msg", RunTimeOnlyIfMatchKind), : Action("msg", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
std::string data(Transaction *Transaction); std::string data(Transaction *Transaction);

View File

@ -25,7 +25,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool MultiMatch::evaluate(RuleWithActions *rule, Transaction *transaction) { bool MultiMatch::execute(RuleWithActions *rule, Transaction *transaction) {
return true; return true;
} }

View File

@ -35,7 +35,7 @@ class MultiMatch : public Action {
explicit MultiMatch(const std::string &action) explicit MultiMatch(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
}; };
} // namespace actions } // namespace actions

View File

@ -26,7 +26,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool NoAuditLog::evaluate(RuleWithActions *rule, Transaction *transaction, bool NoAuditLog::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
transaction->messageSetNoAuditLog(true); transaction->messageSetNoAuditLog(true);
return true; return true;

View File

@ -35,7 +35,7 @@ class NoAuditLog : public Action {
explicit NoAuditLog(const std::string &action) explicit NoAuditLog(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
}; };

View File

@ -29,7 +29,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool NoLog::evaluate(RuleWithActions *rule, Transaction *transaction, bool NoLog::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
return true; return true;
} }

View File

@ -33,7 +33,7 @@ class NoLog : public Action {
explicit NoLog(const std::string &action) explicit NoLog(const std::string &action)
: Action(action, RunTimeOnlyIfMatchKind) { } : Action(action, RunTimeOnlyIfMatchKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
}; };

View File

@ -72,7 +72,7 @@ bool Phase::init(std::string *error) {
} }
bool Phase::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Phase::execute(RuleWithActions *rule, Transaction *transaction) {
rule->setPhase(m_phase); rule->setPhase(m_phase);
return true; return true;
} }

View File

@ -37,7 +37,7 @@ class Phase : public Action {
m_secRulesPhase(0) { } m_secRulesPhase(0) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
int m_phase; int m_phase;
int m_secRulesPhase; int m_secRulesPhase;

View File

@ -33,7 +33,7 @@ bool Rev::init(std::string *error) {
} }
bool Rev::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Rev::execute(RuleWithActions *rule, Transaction *transaction) {
return true; return true;
} }

View File

@ -31,7 +31,7 @@ class Rev : public Action {
public: public:
explicit Rev(const std::string &action) : Action(action, ConfigurationKind) { } explicit Rev(const std::string &action) : Action(action, ConfigurationKind) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
std::string getRevision() const { return m_rev; } std::string getRevision() const { return m_rev; }

View File

@ -48,7 +48,7 @@ bool RuleId::init(std::string *error) {
} }
bool RuleId::evaluate(RuleWithActions *rule, Transaction *transaction) { bool RuleId::execute(RuleWithActions *rule, Transaction *transaction) {
rule->setId(m_ruleId); rule->setId(m_ruleId);
return true; return true;
} }

View File

@ -37,7 +37,7 @@ class RuleId : public Action {
m_ruleId(0) { } m_ruleId(0) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
private: private:
double m_ruleId; double m_ruleId;

View File

@ -31,7 +31,7 @@ bool SetENV::init(std::string *error) {
} }
bool SetENV::evaluate(RuleWithActions *rule, Transaction *t) { bool SetENV::execute(RuleWithActions *rule, Transaction *t) {
std::string colNameExpanded(m_string->evaluate(t)); std::string colNameExpanded(m_string->evaluate(t));
ms_dbg_a(t, 8, "Setting envoriment variable: " ms_dbg_a(t, 8, "Setting envoriment variable: "

View File

@ -39,7 +39,7 @@ class SetENV : public Action {
: Action("setenv", RunTimeOnlyIfMatchKind), : Action("setenv", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -31,7 +31,7 @@ bool SetRSC::init(std::string *error) {
} }
bool SetRSC::evaluate(RuleWithActions *rule, Transaction *t) { bool SetRSC::execute(RuleWithActions *rule, Transaction *t) {
std::string colNameExpanded(m_string->evaluate(t)); std::string colNameExpanded(m_string->evaluate(t));
ms_dbg_a(t, 8, "RESOURCE initiated with value: \'" ms_dbg_a(t, 8, "RESOURCE initiated with value: \'"
+ colNameExpanded + "\'."); + colNameExpanded + "\'.");

View File

@ -39,7 +39,7 @@ class SetRSC : public Action {
: Action("setsrc", RunTimeOnlyIfMatchKind), : Action("setsrc", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -31,7 +31,7 @@ bool SetSID::init(std::string *error) {
} }
bool SetSID::evaluate(RuleWithActions *rule, Transaction *t) { bool SetSID::execute(RuleWithActions *rule, Transaction *t) {
std::string colNameExpanded(m_string->evaluate(t)); std::string colNameExpanded(m_string->evaluate(t));
ms_dbg_a(t, 8, "Session ID initiated with value: \'" ms_dbg_a(t, 8, "Session ID initiated with value: \'"
+ colNameExpanded + "\'."); + colNameExpanded + "\'.");

View File

@ -39,7 +39,7 @@ class SetSID : public Action {
: Action("setsid", RunTimeOnlyIfMatchKind), : Action("setsid", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -31,7 +31,7 @@ bool SetUID::init(std::string *error) {
} }
bool SetUID::evaluate(RuleWithActions *rule, Transaction *t) { bool SetUID::execute(RuleWithActions *rule, Transaction *t) {
std::string colNameExpanded(m_string->evaluate(t)); std::string colNameExpanded(m_string->evaluate(t));
ms_dbg_a(t, 8, "User collection initiated with value: \'" ms_dbg_a(t, 8, "User collection initiated with value: \'"
+ colNameExpanded + "\'."); + colNameExpanded + "\'.");

View File

@ -39,7 +39,7 @@ class SetUID : public Action {
: Action("setuid", RunTimeOnlyIfMatchKind), : Action("setuid", RunTimeOnlyIfMatchKind),
m_string(std::move(z)) { } m_string(std::move(z)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -40,7 +40,7 @@ bool SetVar::init(std::string *error) {
} }
bool SetVar::evaluate(RuleWithActions *rule, Transaction *t) { bool SetVar::execute(RuleWithActions *rule, Transaction *t) {
std::string targetValue; std::string targetValue;
std::string resolvedPre; std::string resolvedPre;

View File

@ -58,7 +58,7 @@ class SetVar : public Action {
m_operation(operation), m_operation(operation),
m_variable(std::move(variable)) { } m_variable(std::move(variable)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
bool init(std::string *error) override; bool init(std::string *error) override;
private: private:

View File

@ -71,7 +71,7 @@ bool Severity::init(std::string *error) {
} }
bool Severity::evaluate(RuleWithActions *rule, Transaction *transaction, bool Severity::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
return true; return true;
} }

View File

@ -35,7 +35,7 @@ class Severity : public Action {
: Action(action), : Action(action),
m_severity(0) { } m_severity(0) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
bool init(std::string *error) override; bool init(std::string *error) override;

View File

@ -38,7 +38,7 @@ bool Skip::init(std::string *error) {
} }
bool Skip::evaluate(RuleWithActions *rule, Transaction *transaction) { bool Skip::execute(RuleWithActions *rule, Transaction *transaction) {
ms_dbg_a(transaction, 5, "Skipping the next " + \ ms_dbg_a(transaction, 5, "Skipping the next " + \
std::to_string(m_skip_next) + " rules."); std::to_string(m_skip_next) + " rules.");

View File

@ -34,7 +34,7 @@ class Skip : public Action {
m_skip_next(0) { } m_skip_next(0) { }
bool init(std::string *error) override; bool init(std::string *error) override;
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
int m_skip_next; int m_skip_next;
}; };

View File

@ -27,7 +27,7 @@ namespace modsecurity {
namespace actions { namespace actions {
bool SkipAfter::evaluate(RuleWithActions *rule, Transaction *transaction) { bool SkipAfter::execute(RuleWithActions *rule, Transaction *transaction) {
ms_dbg_a(transaction, 5, "Setting skipAfter for: " + *m_skipName); ms_dbg_a(transaction, 5, "Setting skipAfter for: " + *m_skipName);
transaction->addMarker(m_skipName); transaction->addMarker(m_skipName);
return true; return true;

View File

@ -34,7 +34,7 @@ class SkipAfter : public Action {
: Action(action, RunTimeOnlyIfMatchKind), : Action(action, RunTimeOnlyIfMatchKind),
m_skipName(std::make_shared<std::string>(m_parser_payload)) { } m_skipName(std::make_shared<std::string>(m_parser_payload)) { }
bool evaluate(RuleWithActions *rule, Transaction *transaction) override; bool execute(RuleWithActions *rule, Transaction *transaction) override;
private: private:
std::shared_ptr<std::string> m_skipName; std::shared_ptr<std::string> m_skipName;
}; };

View File

@ -56,7 +56,7 @@ std::string Tag::getName(Transaction *transaction) {
} }
bool Tag::evaluate(RuleWithActions *rule, Transaction *transaction, bool Tag::execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) { RuleMessage &rm) {
std::string tag = getName(transaction); std::string tag = getName(transaction);
ms_dbg_a(transaction, 9, "Rule tag: " + tag); ms_dbg_a(transaction, 9, "Rule tag: " + tag);

View File

@ -38,7 +38,7 @@ class Tag : public Action {
std::string getName(Transaction *transaction); std::string getName(Transaction *transaction);
bool evaluate(RuleWithActions *rule, Transaction *transaction, bool execute(RuleWithActions *rule, Transaction *transaction,
RuleMessage &rm) override; RuleMessage &rm) override;
protected: protected:

View File

@ -32,7 +32,7 @@ namespace actions {
namespace transformations { namespace transformations {
std::string Base64Decode::evaluate(const std::string &value, std::string Base64Decode::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
std::string ret = Utils::Base64::decode(value); std::string ret = Utils::Base64::decode(value);

View File

@ -32,7 +32,7 @@ class Base64Decode : public Transformation {
public: public:
explicit Base64Decode(const std::string &action) : Transformation(action) { } explicit Base64Decode(const std::string &action) : Transformation(action) { }
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
}; };

View File

@ -32,7 +32,7 @@ namespace actions {
namespace transformations { namespace transformations {
std::string Base64DecodeExt::evaluate(const std::string &value, std::string Base64DecodeExt::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
std::string ret = Utils::Base64::decode_forgiven(value); std::string ret = Utils::Base64::decode_forgiven(value);

View File

@ -32,7 +32,7 @@ class Base64DecodeExt : public Transformation {
public: public:
explicit Base64DecodeExt(const std::string &action) : Transformation(action) { } explicit Base64DecodeExt(const std::string &action) : Transformation(action) { }
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
}; };

View File

@ -32,7 +32,7 @@ namespace actions {
namespace transformations { namespace transformations {
std::string Base64Encode::evaluate(const std::string &value, std::string Base64Encode::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
std::string ret = Utils::Base64::encode(value); std::string ret = Utils::Base64::encode(value);

View File

@ -32,7 +32,7 @@ class Base64Encode : public Transformation {
public: public:
explicit Base64Encode(const std::string &action) : Transformation(action) { } explicit Base64Encode(const std::string &action) : Transformation(action) { }
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
}; };

View File

@ -31,7 +31,7 @@ namespace actions {
namespace transformations { namespace transformations {
std::string CmdLine::evaluate(const std::string &value, std::string CmdLine::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
std::string ret; std::string ret;
int space = 0; int space = 0;

View File

@ -33,7 +33,7 @@ class CmdLine : public Transformation {
explicit CmdLine(const std::string &action) explicit CmdLine(const std::string &action)
: Transformation(action) { } : Transformation(action) { }
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
}; };

View File

@ -35,7 +35,7 @@ CompressWhitespace::CompressWhitespace(const std::string &action)
this->action_kind = 1; this->action_kind = 1;
} }
std::string CompressWhitespace::evaluate(const std::string &value, std::string CompressWhitespace::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
std::string a; std::string a;

View File

@ -30,10 +30,9 @@ namespace transformations {
class CompressWhitespace : public Transformation { class CompressWhitespace : public Transformation {
public: public:
explicit CompressWhitespace(const std::string &action) ; explicit CompressWhitespace(const std::string &action) ;
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
}; };

View File

@ -34,7 +34,7 @@ namespace actions {
namespace transformations { namespace transformations {
std::string CssDecode::evaluate(const std::string &value, std::string CssDecode::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
char *tmp = reinterpret_cast<char *>( char *tmp = reinterpret_cast<char *>(

View File

@ -33,7 +33,7 @@ class CssDecode : public Transformation {
public: public:
explicit CssDecode(const std::string &action) explicit CssDecode(const std::string &action)
: Transformation(action) { } : Transformation(action) { }
std::string evaluate(const std::string &exp, std::string execute(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
static int css_decode_inplace(unsigned char *input, int64_t input_len); static int css_decode_inplace(unsigned char *input, int64_t input_len);

View File

@ -140,7 +140,7 @@ int EscapeSeqDecode::ansi_c_sequences_decode_inplace(unsigned char *input,
} }
std::string EscapeSeqDecode::evaluate(const std::string &value, std::string EscapeSeqDecode::execute(const std::string &value,
Transaction *transaction) { Transaction *transaction) {
unsigned char *tmp = (unsigned char *) malloc(sizeof(char) unsigned char *tmp = (unsigned char *) malloc(sizeof(char)

View File

@ -30,10 +30,8 @@ namespace transformations {
class EscapeSeqDecode : public Transformation { class EscapeSeqDecode : public Transformation {
public: public:
explicit EscapeSeqDecode(const std::string &action) ; explicit EscapeSeqDecode(const std::string &action) ;
std::string execute(const std::string &exp,
std::string evaluate(const std::string &exp,
Transaction *transaction) override; Transaction *transaction) override;
static int ansi_c_sequences_decode_inplace(unsigned char *input, int input_len); static int ansi_c_sequences_decode_inplace(unsigned char *input, int input_len);
}; };

Some files were not shown because too many files have changed in this diff Show More