github_mirrors/ModSecurity
3
0
Fork 1
mirror of https://github.com/owasp-modsecurity/ModSecurity.git synced 2025-08-16 07:56:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix resource leaks in msc_status_engine_mac_address

Browse Source 
`goto end` jumped over freeing/releasing resources for all platforms.

For Linux, this caused a leak of open socket. For other platforms, it's
just a memory leak.
This commit is contained in:
Aleksandr Mezin 2025-05-27 09:38:02 +03:00 committed by Aleksandr Mezin
parent a217cb1056
commit 0a70b0e343
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apache2/msc_status_engine.c
View File

@ -182,7 +182,7 @@ int DSOLOCAL msc_status_engine_mac_address (unsigned char *mac)
(unsigned char)LLADDR(sdl)[3], (unsigned char)LLADDR(sdl)[3],
(unsigned char)LLADDR(sdl)[4], (unsigned char)LLADDR(sdl)[4],
(unsigned char)LLADDR(sdl)[5]); (unsigned char)LLADDR(sdl)[5]);
goto end; break;
} }
} }
@ -225,7 +225,7 @@ int DSOLOCAL msc_status_engine_mac_address (unsigned char *mac)
(unsigned char)ifr->ifr_addr.sa_data[4], (unsigned char)ifr->ifr_addr.sa_data[4],
(unsigned char)ifr->ifr_addr.sa_data[5]); (unsigned char)ifr->ifr_addr.sa_data[5]);
goto end; break;
} }
} }
close( sock ); close( sock );
@ -268,7 +268,7 @@ int DSOLOCAL msc_status_engine_mac_address (unsigned char *mac)
(unsigned char)pAdapter->Address[3], (unsigned char)pAdapter->Address[3],
(unsigned char)pAdapter->Address[4], (unsigned char)pAdapter->Address[4],
(unsigned char)pAdapter->Address[5]); (unsigned char)pAdapter->Address[5]);
goto end; break;
} }
pAdapter = pAdapter->Next; pAdapter = pAdapter->Next;
} }
@ -276,7 +276,6 @@ int DSOLOCAL msc_status_engine_mac_address (unsigned char *mac)
free(pAdapterInfo); free(pAdapterInfo);
#endif #endif
end:
return 0; return 0;
failed: failed:
return -1; return -1;