From 038522ad9b69466cf0e8adf32a388ee7ebf0bcfa Mon Sep 17 00:00:00 2001 From: Ervin Hegedus Date: Wed, 10 Jul 2019 15:33:39 +0000 Subject: [PATCH] Small fixes in log messages to help debugging --- CHANGES | 2 ++ src/request_body_processor/multipart.cc | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGES b/CHANGES index 943ae6ea..80ce099c 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,8 @@ v3.0.4 - YYYY-MMM-DD (to be released) ------------------------------------- + - Small fixes in log messages to help debugging the file upload + [Issue #2130 - @airween] - Fix Cookie header parsing issues [Issue #2201 - @airween, @martinhsv] - Fix rules with nolog are logging to part H diff --git a/src/request_body_processor/multipart.cc b/src/request_body_processor/multipart.cc index 37919128..b38d0986 100644 --- a/src/request_body_processor/multipart.cc +++ b/src/request_body_processor/multipart.cc @@ -70,7 +70,7 @@ Multipart::Multipart(std:: string header, Transaction *transaction) Multipart::~Multipart() { ms_dbg_a(m_transaction, 4, - "Multipart: Cleanup started (remove files " \ + "Multipart: Cleanup started (keep files set to " \ + RulesProperties::configBooleanString( m_transaction->m_rules->m_uploadKeepFiles) \ + ")"); @@ -96,7 +96,7 @@ Multipart::~Multipart() { + strerror(errno) + ")"); } else { ms_dbg_a(m_transaction, 4, - "Multipart: Failed to delete file (part) \"" \ + "Multipart: file deleted successfully (part) \"" \ + m->m_tmp_file_name + "\""); } @@ -516,7 +516,7 @@ int Multipart::process_part_data(std::string *error, size_t offset) { ms_dbg_a(m_transaction, 4, "Multipart: Created temporary file " \ - + std::to_string(m_nfiles) + " (mode 04o): " \ + + std::to_string(m_nfiles) + " (mode o" + std::to_string(m_transaction->m_rules->m_uploadFileMode.m_value) + "): " \ + m_mpp->m_tmp_file_name); }